Add support to log slow queries in Frontend #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilles42
force-pushed
the
log-slow-queries
branch
from
c6698c2 to
46660d1
Compare
achilles42
changed the title
achilles42
changed the title
achilles42
force-pushed
the
log-slow-queries
branch
from
46660d1 to
8d2bf57
Compare
khaines
reviewed
Oct 23, 2019
There was a problem hiding this comment.
Hey @achilles42, thank you for the PR! I think it's an important effort to surface slow query details.
I've left a few comments, so please have a look.
achilles42
force-pushed
the
log-slow-queries
branch
2 times, most recently
from
66c9569 to
010cd35
Compare
khaines
approved these changes
Oct 25, 2019
gouthamve
approved these changes
Oct 30, 2019
|
Could you also add a changelog entry? |
achilles42
force-pushed
the
log-slow-queries
branch
3 times, most recently
from
4d92fec to
67dd154
Compare
|
pracucci
reviewed
Oct 31, 2019
gouthamve
reviewed
Oct 31, 2019
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
achilles42
force-pushed
the
log-slow-queries
branch
from
8649f8c to
ae6c234
Compare
gouthamve
reviewed
Nov 4, 2019
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Signed-off-by: Praveen Shukla <praveen.shukla.c42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a feature to log slow queries in Frontend based on
querier.log-queries-longer-thanparameter. As per this discussion on issue 1567cc @gouthamve