Ensure queries are cancelled correctly via the frontend. #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And test it works. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
dont-retry-cancelled-queries
branch
from
1c96c7e to
089c384
Compare
tomwilkie
changed the title
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
|
Fixes #1313 ? |
|
Yes! Sorry didn't know we had an issue for that. |
gouthamve
reviewed
Jul 16, 2019
| case err := <-errChan: | ||
| request.err <- err | ||
| // If the upstream reqeust is cancelled, we need to cancel the | ||
| // downstream req. Only way we can do that is to close the stream. |
There was a problem hiding this comment.
This means if 5 requests are being handled on this stream, all of them will error out?
There was a problem hiding this comment.
This means a user can DOS the service by just sending requests and immediately cancelling them.
There was a problem hiding this comment.
There should only ever be one concurrent request per stream, so I don't think this is a problem.
gouthamve
approved these changes
Jul 17, 2019
| case err := <-errChan: | ||
| request.err <- err | ||
| // If the upstream reqeust is cancelled, we need to cancel the | ||
| // downstream req. Only way we can do that is to close the stream. |
|
As far as I can see this isn't working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com
Should mostly be a simplification of the frontend.Process method's concurrency. And an extra goroutine in the client for this (worker.go).
And a unit test to show it works now.