Skip to content

Ruler rules manager/querier should log trace ID's #2964

Open
@cstyan

Description

@cstyan

Because rule evaluation for the ruler is started via the upstream Prometheus rules manager we don't have control over it's logging. The ruler passes a Querier to the rules manager as the Queryable.

The Querier starts it's own spans and logs trace IDs via spanlogger, but it's not immediately clear to me how we could have that trace ID logged when rule evaluation fails.

In order to debug things like rule evaluation failed in the Ruler with traces stored in some tracing backends, it would be very beneficial to have trace IDs logged.

cc @gotjosh @jtlisi

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/rulesBits & bobs todo with rules and alerts: the ruler, config service etc.keepaliveSkipped by stale bottype/observabilityTo help know what is going on inside Cortex

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions