Review comments.

Signed-off-by: Steve Simpson <steve.simpson@grafana.com>

Author: stevesg

docs/configuration/config-file-reference.md

@@ -3798,8 +3798,8 @@ The `memberlist_config` configures the Gossip memberlist.
 
 # Enable message compression. This can be used to reduce bandwidth usage at the
 # cost of slightly more CPU utilization.
-# CLI flag: -memberlist.enable-compression
-[enable_compression: <boolean> | default = true]
+# CLI flag: -memberlist.compression-enabled
+[compression_enabled: <boolean> | default = true]
 
 # Other cluster members to join. Can be specified multiple times. It can be an
 # IP, hostname or an entry specified in the DNS Service Discovery format (see

integration/integration_memberlist_single_binary_test.go

@@ -32,7 +32,7 @@ func TestSingleBinaryWithMemberlist(t *testing.T) {
 
 	t.Run("compression-disabled", func(t *testing.T) {
 		testSingleBinaryEnv(t, false, map[string]string{
-			"-memberlist.enable-compression": "false",
+			"-memberlist.compression-enabled": "false",
 		})
 	})
 }

pkg/ring/kv/memberlist/memberlist_client.go

@@ -136,7 +136,7 @@ type KVConfig struct {
 	GossipNodes         int           `yaml:"gossip_nodes"`
 	GossipToTheDeadTime time.Duration `yaml:"gossip_to_dead_nodes_time"`
 	DeadNodeReclaimTime time.Duration `yaml:"dead_node_reclaim_time"`
-	EnableCompression   bool          `yaml:"enable_compression"`
+	EnableCompression   bool          `yaml:"compression_enabled"`
 
 	// List of members to join
 	JoinMembers      flagext.StringSlice `yaml:"join_members"`
@@ -188,7 +188,7 @@ func (cfg *KVConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix string) {
 	f.DurationVar(&cfg.GossipToTheDeadTime, prefix+"memberlist.gossip-to-dead-nodes-time", mlDefaults.GossipToTheDeadTime, "How long to keep gossiping to dead nodes, to give them chance to refute their death.")
 	f.DurationVar(&cfg.DeadNodeReclaimTime, prefix+"memberlist.dead-node-reclaim-time", mlDefaults.DeadNodeReclaimTime, "How soon can dead node's name be reclaimed with new address. 0 to disable.")
 	f.IntVar(&cfg.MessageHistoryBufferBytes, prefix+"memberlist.message-history-buffer-bytes", 0, "How much space to use for keeping received and sent messages in memory for troubleshooting (two buffers). 0 to disable.")
-	f.BoolVar(&cfg.EnableCompression, prefix+"memberlist.enable-compression", mlDefaults.EnableCompression, "Enable message compression. This can be used to reduce bandwidth usage at the cost of slightly more CPU utilization.")
+	f.BoolVar(&cfg.EnableCompression, prefix+"memberlist.compression-enabled", mlDefaults.EnableCompression, "Enable message compression. This can be used to reduce bandwidth usage at the cost of slightly more CPU utilization.")
 
 	cfg.TCPTransport.RegisterFlags(f, prefix)
 }