ensure zstd reader is closed after decompression

afhassan · afhassan · commit cdbb153c02b7 · 2025-07-18T12:45:05.000-07:00
Signed-off-by: Ahmed Hassan &lt;afayekhassan@gmail.com&gt;
diff --git a/pkg/querier/tripperware/query.go b/pkg/querier/tripperware/query.go
@@ -495,7 +495,7 @@ func decode(buf *bytes.Buffer, encoding string, logger log.Logger) ([]byte, erro
 		if err != nil {
 			return nil, err
 		}
-		defer runutil.CloseWithLogOnErr(logger, io.NopCloser(zReader), "close zstd decoder")
+		defer runutil.CloseWithLogOnErr(logger, zReader.IOReadCloser(), "close zstd decoder")
 
 		return io.ReadAll(zReader)
 	}

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,7 @@ func decode(buf *bytes.Buffer, encoding string, logger log.Logger) ([]byte, erro`
`495`	`495`	`if err != nil {`
`496`	`496`	`return nil, err`
`497`	`497`	`}`
`498`		`- defer runutil.CloseWithLogOnErr(logger, io.NopCloser(zReader), "close zstd decoder")`
	`498`	`+ defer runutil.CloseWithLogOnErr(logger, zReader.IOReadCloser(), "close zstd decoder")`
`499`	`499`
`500`	`500`	`return io.ReadAll(zReader)`
`501`	`501`	`}`