Fix incorrectly named cache metrics

Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>

Author: harry671003

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## master / unreleased
 
 * [FEATURE] Ruler: Add `external_labels` option to tag all alerts with a given set of labels.
+* [CHANGE] Fix incorrectly named `cortex_cache_fetched_keys` and `cortex_cache_hits` metrics. Renamed to `cortex_cache_fetched_keys_total` and `cortex_cache_hits_total` respectively. #4686
 
 ## 1.12.0 in progress
 

pkg/chunk/cache/instrumented.go

@@ -38,14 +38,14 @@ func Instrument(name string, cache Cache, reg prometheus.Registerer) Cache {
 
 		fetchedKeys: promauto.With(reg).NewCounter(prometheus.CounterOpts{
 			Namespace:   "cortex",
-			Name:        "cache_fetched_keys",
+			Name:        "cache_fetched_keys_total",
 			Help:        "Total count of keys requested from cache.",
 			ConstLabels: prometheus.Labels{"name": name},
 		}),
 
 		hits: promauto.With(reg).NewCounter(prometheus.CounterOpts{
 			Namespace:   "cortex",
-			Name:        "cache_hits",
+			Name:        "cache_hits_total",
 			Help:        "Total count of keys found in cache.",
 			ConstLabels: prometheus.Labels{"name": name},
 		}),