Skip to content

Commit 79259ae

Browse files
authored
Update cortex_ingester_inflight_push_requests metric description (#6438)
Signed-off-by: alanprot <alanprot@gmail.com>
1 parent 3ec967b commit 79259ae

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* [CHANGE] Change all max async concurrency default values `50` to `3` #6268
1010
* [CHANGE] Change default value of `-blocks-storage.bucket-store.index-cache.multilevel.max-async-concurrency` from `50` to `3` #6265
1111
* [CHANGE] Enable Compactor and Alertmanager in target all. #6204
12+
* [CHANGE] Update the `cortex_ingester_inflight_push_requests` metric to represent the maximum number of inflight requests recorded in the last minute. #6437
1213
* [FEATURE] Ruler: Pagination support for List Rules API. #6299
1314
* [FEATURE] Query Frontend/Querier: Add protobuf codec `-api.querier-default-codec` and the option to choose response compression type `-querier.response-compression`. #5527
1415
* [FEATURE] Ruler: Experimental: Add `ruler.frontend-address` to allow query to query frontends instead of ingesters. #6151

pkg/ingester/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ func newIngesterMetrics(r prometheus.Registerer,
216216

217217
inflightRequests: promauto.With(r).NewGaugeFunc(prometheus.GaugeOpts{
218218
Name: "cortex_ingester_inflight_push_requests",
219-
Help: "Current number of inflight push requests in ingester.",
219+
Help: "Max number of inflight push requests in ingester in the last minute.",
220220
}, func() float64 {
221221
if inflightPushRequests != nil {
222222
return float64(inflightPushRequests.Load())

pkg/ingester/metrics_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func TestIngesterMetrics(t *testing.T) {
3939
require.NotNil(t, m)
4040

4141
err := testutil.GatherAndCompare(mainReg, bytes.NewBufferString(`
42-
# HELP cortex_ingester_inflight_push_requests Current number of inflight push requests in ingester.
42+
# HELP cortex_ingester_inflight_push_requests Max number of inflight push requests in ingester in the last minute.
4343
# TYPE cortex_ingester_inflight_push_requests gauge
4444
cortex_ingester_inflight_push_requests 14
4545
# HELP cortex_ingester_max_inflight_query_requests Max number of inflight query requests in ingester.

0 commit comments

Comments
 (0)