Skip to content

Commit 5e813a2

Browse files
authored
Enforce seconds unit in the querier wall time log (#3695)
Signed-off-by: Marco Pracucci <marco@pracucci.com>
1 parent b1be491 commit 5e813a2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* `-bigtable.grpc-use-gzip-compression`: use `-bigtable.grpc-compression` instead
1111
* `-ingester.client.grpc-use-gzip-compression`: use `-ingester.client.grpc-compression` instead
1212
* `-querier.frontend-client.grpc-use-gzip-compression`: use `-querier.frontend-client.grpc-compression` instead
13-
* [CHANGE] Querier: it's not required to set `-frontend.query-stats-enabled=true` in the querier anymore to enable query statistics logging in the query-frontend. The flag is now required to be configured only in the query-frontend and it will be propagated to the queriers. #3595
13+
* [CHANGE] Querier: it's not required to set `-frontend.query-stats-enabled=true` in the querier anymore to enable query statistics logging in the query-frontend. The flag is now required to be configured only in the query-frontend and it will be propagated to the queriers. #3595 #3693
1414
* [CHANGE] Blocks storage: compactor is now required when running a Cortex cluster with the blocks storage, because it also keeps the bucket index updated. #3583
1515
* [CHANGE] Blocks storage: block deletion marks are now stored in a per-tenant global markers/ location too, other than within the block location. The compactor, at startup, will copy deletion marks from the block location to the global location. This migration is required only once, so you can safely disable it via `-compactor.block-deletion-marks-migration-enabled=false` once new compactor has successfully started once in your cluster. #3583
1616
* [CHANGE] OpenStack Swift: the default value for the `-ruler.storage.swift.container-name` and `-swift.container-name` config options has changed from `cortex` to empty string. If you were relying on the default value, you should set it back to `cortex`. #3660

pkg/frontend/transport/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ func (f *Handler) reportQueryStats(r *http.Request, queryString url.Values, quer
161161
"method", r.Method,
162162
"path", r.URL.Path,
163163
"response_time", queryResponseTime,
164-
"query_wall_time", stats.LoadWallTime(),
164+
"query_wall_time_seconds", stats.LoadWallTime().Seconds(),
165165
}, formatQueryString(queryString)...)
166166

167167
level.Info(util.WithContext(r.Context(), f.log)).Log(logMessage...)

0 commit comments

Comments
 (0)