Skip to content

Commit 59fc644

Browse files
committed
Add descriptionw when using Thanos Promql engine
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
1 parent ab54ed7 commit 59fc644

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

docs/configuration/config-file-reference.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3994,7 +3994,9 @@ The `limits_config` configures default and per-tenant limits imposed by Cortex s
39943994
[promote_resource_attributes: <list of string> | default = ]
39953995
39963996
# EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics.
3997-
# This applies to remote write v2 and OTLP requests.
3997+
# This applies to remote write v2 and OTLP requests. When using the Thanos
3998+
# PromQL engine, the `__type__` and `__unit__` labels are currently not dropped
3999+
# along with the `__name__` label.
39984000
# CLI flag: -distributor.enable-type-and-unit-labels
39994001
[enable_type_and_unit_labels: <boolean> | default = false]
40004002

pkg/util/validation/limits.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
265265
f.IntVar(&l.HAMaxClusters, "distributor.ha-tracker.max-clusters", 0, "Maximum number of clusters that HA tracker will keep track of for single user. 0 to disable the limit.")
266266
f.Var((*flagext.StringSliceCSV)(&l.PromoteResourceAttributes), "distributor.promote-resource-attributes", "Comma separated list of resource attributes that should be converted to labels.")
267267
f.Var(&l.DropLabels, "distributor.drop-label", "This flag can be used to specify label names that to drop during sample ingestion within the distributor and can be repeated in order to drop multiple labels.")
268-
f.BoolVar(&l.EnableTypeAndUnitLabels, "distributor.enable-type-and-unit-labels", false, "EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics. This applies to remote write v2 and OTLP requests.")
268+
f.BoolVar(&l.EnableTypeAndUnitLabels, "distributor.enable-type-and-unit-labels", false, "EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics. This applies to remote write v2 and OTLP requests. When using the Thanos PromQL engine, the `__type__` and `__unit__` labels are currently not dropped along with the `__name__` label.")
269269
f.IntVar(&l.MaxLabelNameLength, "validation.max-length-label-name", 1024, "Maximum length accepted for label names")
270270
f.IntVar(&l.MaxLabelValueLength, "validation.max-length-label-value", 2048, "Maximum length accepted for label value. This setting also applies to the metric name")
271271
f.IntVar(&l.MaxLabelNamesPerSeries, "validation.max-label-names-per-series", 30, "Maximum number of label names per series.")

schemas/cortex-config-schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4942,7 +4942,7 @@
49424942
},
49434943
"enable_type_and_unit_labels": {
49444944
"default": false,
4945-
"description": "EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics. This applies to remote write v2 and OTLP requests.",
4945+
"description": "EXPERIMENTAL: If true, the __type__ and __unit__ labels are added to metrics. This applies to remote write v2 and OTLP requests. When using the Thanos PromQL engine, the `__type__` and `__unit__` labels are currently not dropped along with the `__name__` label.",
49464946
"type": "boolean",
49474947
"x-cli-flag": "distributor.enable-type-and-unit-labels"
49484948
},

0 commit comments

Comments
 (0)