Skip to content

Commit 3949954

Browse files
authored
Fix default_validity cache setting typo (#2140)
Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
1 parent 61cf007 commit 3949954

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* `--store.min-chunk-age` has been removed
99
* `--querier.query-store-after` has been added in it's place.
1010
* [CHANGE] Experimental Memberlist KV store can now be used in single-binary Cortex. Attempts to use it previously would fail with panic. This change also breaks existing binary protocol used to exchange gossip messages, so this version will not be able to understand gossiped Ring when used in combination with the previous version of Cortex. Easiest way to upgrade is to shutdown old Cortex installation, and restart it with new version. Incremental rollout works too, but with reduced functionality until all components run the same version. #2016
11+
* [CHANGE] Renamed the cache configuration setting `defaul_validity` to `default_validity`. #2140
1112
* [FEATURE] Added user sub rings to distribute users to a subset of ingesters. #1947
1213
* `--experimental.distributor.user-subring-size`
1314
* [FEATURE] Added flag `-experimental.ruler.enable-api` to enable the ruler api which implements the Prometheus API `/api/v1/rules` and `/api/v1/alerts` endpoints under the configured `-http.prefix`. #1999

docs/configuration/config-file-reference.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ results_cache:
604604
605605
# The default validity of entries for caches unless overridden.
606606
# CLI flag: -frontend.default-validity
607-
[defaul_validity: <duration> | default = 0s]
607+
[default_validity: <duration> | default = 0s]
608608
609609
background:
610610
# How many goroutines to use to write back to memcache.
@@ -1457,7 +1457,7 @@ index_queries_cache_config:
14571457
# Cache config for index entry reading. The default validity of entries for
14581458
# caches unless overridden.
14591459
# CLI flag: -store.index-cache-read.default-validity
1460-
[defaul_validity: <duration> | default = 0s]
1460+
[default_validity: <duration> | default = 0s]
14611461

14621462
background:
14631463
# Cache config for index entry reading. How many goroutines to use to write
@@ -1502,7 +1502,7 @@ chunk_cache_config:
15021502
# Cache config for chunks. The default validity of entries for caches unless
15031503
# overridden.
15041504
# CLI flag: -default-validity
1505-
[defaul_validity: <duration> | default = 0s]
1505+
[default_validity: <duration> | default = 0s]
15061506
15071507
background:
15081508
# Cache config for chunks. How many goroutines to use to write back to
@@ -1537,7 +1537,7 @@ write_dedupe_cache_config:
15371537
# Cache config for index entry writing. The default validity of entries for
15381538
# caches unless overridden.
15391539
# CLI flag: -store.index-cache-write.default-validity
1540-
[defaul_validity: <duration> | default = 0s]
1540+
[default_validity: <duration> | default = 0s]
15411541
15421542
background:
15431543
# Cache config for index entry writing. How many goroutines to use to write

go.sum

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,7 @@ github.com/segmentio/fasthash v0.0.0-20180216231524-a72b379d632e h1:uO75wNGioszj
709709
github.com/segmentio/fasthash v0.0.0-20180216231524-a72b379d632e/go.mod h1:tm/wZFQ8e24NYaBGIlnO2WGCAi67re4HHuOm0sftE/M=
710710
github.com/sercand/kuberesolver v2.1.0+incompatible h1:iJ1oCzPQ/aacsbCWLfJW1hPKkHMvCEgNSA9kvWcb9MY=
711711
github.com/sercand/kuberesolver v2.1.0+incompatible/go.mod h1:lWF3GL0xptCB/vCiJPl/ZshwPsX/n4Y7u0CW9E7aQIQ=
712+
github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24 h1:pntxY8Ary0t43dCZ5dqY4YTJCObLY1kIXl0uzMv+7DE=
712713
github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24/go.mod h1:M+9NzErvs504Cn4c5DxATwIqPbtswREoFCre64PpcG4=
713714
github.com/shurcooL/httpfs v0.0.0-20171119174359-809beceb2371/go.mod h1:ZY1cvUeJuFPAdZ/B6v7RHavJWZn2YPVFQ1OSXhCGOkg=
714715
github.com/shurcooL/httpfs v0.0.0-20190707220628-8d4bc4ba7749 h1:bUGsEnyNbVPw06Bs80sCeARAlK8lhwqGyi6UT8ymuGk=

pkg/chunk/cache/cache.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ type Cache interface {
2424
type Config struct {
2525
EnableFifoCache bool `yaml:"enable_fifocache,omitempty"`
2626

27-
DefaultValidity time.Duration `yaml:"defaul_validity,omitempty"`
27+
DefaultValidity time.Duration `yaml:"default_validity,omitempty"`
2828

2929
Background BackgroundConfig `yaml:"background,omitempty"`
3030
Memcache MemcachedConfig `yaml:"memcached,omitempty"`

0 commit comments

Comments
 (0)