Skip to content

Commit 2c22662

Browse files
authored
Improve wording of --query-store-after description (#3628)
* Improve wording of --query-store-after description The two cases controlled by this flag are "just ingesters" and "ingesters plus store", so saying "only be queried from storage" was confusing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Add missed doc file Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
1 parent 4889f38 commit 2c22662

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

docs/blocks-storage/querier.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,11 @@ querier:
132132
# CLI flag: -querier.query-store-for-labels-enabled
133133
[query_store_for_labels_enabled: <boolean> | default = false]
134134

135-
# The time after which a metric should only be queried from storage and not
136-
# just ingesters. 0 means all queries are sent to store. When running the
137-
# blocks storage, if this option is enabled, the time range of the query sent
138-
# to the store will be manipulated to ensure the query end is not more recent
139-
# than 'now - query-store-after'.
135+
# The time after which a metric should be queried from storage and not just
136+
# ingesters. 0 means all queries are sent to store. When running the blocks
137+
# storage, if this option is enabled, the time range of the query sent to the
138+
# store will be manipulated to ensure the query end is not more recent than
139+
# 'now - query-store-after'.
140140
# CLI flag: -querier.query-store-after
141141
[query_store_after: <duration> | default = 0s]
142142

docs/configuration/config-file-reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ The `querier_config` configures the Cortex querier.
788788
# CLI flag: -querier.query-store-for-labels-enabled
789789
[query_store_for_labels_enabled: <boolean> | default = false]
790790
791-
# The time after which a metric should only be queried from storage and not just
791+
# The time after which a metric should be queried from storage and not just
792792
# ingesters. 0 means all queries are sent to store. When running the blocks
793793
# storage, if this option is enabled, the time range of the query sent to the
794794
# store will be manipulated to ensure the query end is not more recent than 'now

pkg/querier/querier.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
9191
f.BoolVar(&cfg.QueryStoreForLabels, "querier.query-store-for-labels-enabled", false, "Query long-term store for series, label values and label names APIs. Works only with blocks engine.")
9292
f.DurationVar(&cfg.MaxQueryIntoFuture, "querier.max-query-into-future", 10*time.Minute, "Maximum duration into the future you can query. 0 to disable.")
9393
f.DurationVar(&cfg.DefaultEvaluationInterval, "querier.default-evaluation-interval", time.Minute, "The default evaluation interval or step size for subqueries.")
94-
f.DurationVar(&cfg.QueryStoreAfter, "querier.query-store-after", 0, "The time after which a metric should only be queried from storage and not just ingesters. 0 means all queries are sent to store. When running the blocks storage, if this option is enabled, the time range of the query sent to the store will be manipulated to ensure the query end is not more recent than 'now - query-store-after'.")
94+
f.DurationVar(&cfg.QueryStoreAfter, "querier.query-store-after", 0, "The time after which a metric should be queried from storage and not just ingesters. 0 means all queries are sent to store. When running the blocks storage, if this option is enabled, the time range of the query sent to the store will be manipulated to ensure the query end is not more recent than 'now - query-store-after'.")
9595
f.StringVar(&cfg.ActiveQueryTrackerDir, "querier.active-query-tracker-dir", "./active-query-tracker", "Active query tracker monitors active queries, and writes them to the file in given directory. If Cortex discovers any queries in this log during startup, it will log them to the log file. Setting to empty value disables active query tracker, which also disables -querier.max-concurrent option.")
9696
f.StringVar(&cfg.StoreGatewayAddresses, "querier.store-gateway-addresses", "", "Comma separated list of store-gateway addresses in DNS Service Discovery format. This option should be set when using the blocks storage and the store-gateway sharding is disabled (when enabled, the store-gateway instances form a ring and addresses are picked from the ring).")
9797
f.DurationVar(&cfg.LookbackDelta, "querier.lookback-delta", 5*time.Minute, "Time since the last sample after which a time series is considered stale and ignored by expression evaluations.")

0 commit comments

Comments
 (0)