fix unit tests

Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

Author: jtlisi

pkg/ruler/notifier_test.go

@@ -46,7 +46,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 									},
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 					},
 				},
@@ -74,7 +73,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 									Port:            0,
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 					},
 				},
@@ -106,7 +104,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 								},
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 						{
 							APIVersion: "v1",
@@ -118,7 +115,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 								},
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 					},
 				},
@@ -146,7 +142,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 									Port:            0,
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 						{
 							APIVersion: "v1",
@@ -160,7 +155,6 @@ func TestBuildNotifierConfig(t *testing.T) {
 									Port:            0,
 								},
 							},
-							HTTPClientConfig: config_util.HTTPClientConfig{BasicAuth: &config_util.BasicAuth{}},
 						},
 					},
 				},

pkg/util/http.go

@@ -33,7 +33,7 @@ func (b *BasicAuth) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) {
 
 // IsEnabled returns false if basic authentication isn't enabled.
 func (b BasicAuth) IsEnabled() bool {
-	return b.Username == "" && b.Password == ""
+	return b.Username != "" || b.Password != ""
 }
 
 // WriteJSONResponse writes some JSON as a HTTP response.