Skip to content

Commit 13da9fb

Browse files
committed
fix error message
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
1 parent 21037c0 commit 13da9fb

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

integration/remote_write_v2_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ func TestIngest_SenderSendPRW2_DistributorNotAllowPRW2(t *testing.T) {
194194
symbols1, series, _ := e2e.GenerateSeriesV2("test_series", now, prompb.Label{Name: "job", Value: "test"}, prompb.Label{Name: "foo", Value: "bar"})
195195
_, err = c.PushV2(symbols1, series)
196196
require.Error(t, err)
197-
require.Contains(t, err.Error(), "server returned HTTP status 415 Unsupported Media Type: Remote Write V2 is disabled")
197+
require.Contains(t, err.Error(), "io.prometheus.write.v2.Request protobuf message is not accepted by this server; only accepts prometheus.WriteRequest")
198198

199199
// sample
200200
result, err := c.Query("test_series", now)

pkg/util/push/push.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ func Handler(remoteWrite2Enabled bool, maxRecvMsgSize int, overrides *validation
170170
handlePRW1()
171171
case remote.WriteV2MessageType:
172172
if !remoteWrite2Enabled {
173-
http.Error(w, "Remote Write V2 is disabled", http.StatusUnsupportedMediaType)
173+
errMsg := fmt.Sprintf("%v protobuf message is not accepted by this server; only accepts %v", msgType, remote.WriteV1MessageType)
174+
http.Error(w, errMsg, http.StatusUnsupportedMediaType)
174175
return
175176
}
176177
handlePRW2()

0 commit comments

Comments
 (0)