Skip to content

Improve signature def detection #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2019
Merged

Improve signature def detection #460

merged 5 commits into from
Sep 16, 2019

Conversation

vishalbollu
Copy link
Contributor

Closes #451

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu September 13, 2019 18:29
deliahu
deliahu reviewed Sep 16, 2019
View reviewed changes
deliahu
deliahu reviewed Sep 16, 2019
View reviewed changes
@vishalbollu vishalbollu merged commit 5d434b3 into master Sep 16, 2019
@vishalbollu vishalbollu deleted the improve-signature-def-detection branch September 16, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help users automatically detect signature key
2 participants
@vishalbollu @deliahu