Skip to content

Only read Cortex config from cortex.yaml #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2019
Merged

Only read Cortex config from cortex.yaml #396

merged 2 commits into from
Aug 28, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Aug 28, 2019 •
edited
Loading

Closes #387

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@deliahu deliahu requested a review from 1vn August 28, 2019 18:07
1vn
1vn approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deliahu deliahu merged commit 1e0df13 into master Aug 28, 2019
@deliahu deliahu deleted the single-cortex-config branch August 28, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1vn 1vn 1vn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only read Cortex config from cortex.yaml
2 participants
@deliahu @1vn