Skip to content

Overload print builtin #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Overload print builtin #377

merged 6 commits into from
Aug 27, 2019

Conversation

1vn
Copy link
Contributor

@1vn 1vn commented Aug 26, 2019

Closes #339


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - you should also get LGTM from Vishal if you haven't

@1vn 1vn requested a review from vishalbollu August 26, 2019 22:37
@vishalbollu
Copy link
Contributor

You should do the same for ONNX and test that it works for ONNX apis

@deliahu deliahu merged commit 14ffed8 into master Aug 27, 2019
@deliahu deliahu deleted the overload-print branch August 27, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve user logging
3 participants