Bug fix column list transform input #3
Conversation
|
|
||
| for alias in transform_resource["aliases"]: | ||
| input_cols = sorted(transform_resource["inputs"]["features"].values()) | ||
| for alias in transformed_feature["aliases"][1:]: | ||
| logger.info("Transforming {} to {}".format(", ".join(input_cols), alias)) |
There was a problem hiding this comment.
This is a bit of an edge case, and it actually isn't possible until we allow chained transformations, but in theory there could be an alias transformed feature that uses aliased features as inputs, so it might be worth it to re-generate the names of the input cols. You could make a helper in context.py that does this and call it twice here (once for the actual transformation, and once for each additional alias). But since right now we don't have chained transformations and raw feature aliases are not allowed, it actually isn't an issue at the moment, so we can address this in the future when we add chained transformations.
There was a problem hiding this comment.
Yea definitely a case that we need to look out for, good point.
No description provided.