Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TCP probe to target port if no readiness probe is found in the API spec #2379

Merged
merged 7 commits into from
Aug 3, 2021
Merged

Add TCP probe to target port if no readiness probe is found in the API spec #2379

merged 7 commits into from
Aug 3, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 29, 2021 •
edited
Loading

  • Only applicable to the RealtimeAPI kind.
  • Increase the timeout and failure threshold from 1 to 3.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added ux User experience RealtimeAPI Something related to the RealtimeAPI kind labels Jul 29, 2021
@RobertLucian RobertLucian merged commit 83eb9f6 into master Aug 3, 2021
@RobertLucian RobertLucian deleted the misc/default-proxy-probe branch August 3, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
RealtimeAPI Something related to the RealtimeAPI kind ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu