Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --print-config display yaml that is consumable by cortex configure #2324

Merged
merged 7 commits into from
Jul 12, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 8, 2021

Refactor cluster configuration so to make it easy to allow --print-config to print a valid cluster configuration file that can be consumed by other cortex commands.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

pkg/types/clusterconfig/cluster_config.go Outdated Show resolved Hide resolved
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant implementation!

@vishalbollu vishalbollu merged commit f67de1a into master Jul 12, 2021
@vishalbollu vishalbollu deleted the print-configurable-config branch July 12, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants