Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cluster-autoscaler-priority expander #2309

Merged
merged 3 commits into from
Jul 3, 2021
Merged

Fix cluster-autoscaler-priority expander #2309

merged 3 commits into from
Jul 3, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 2, 2021 •
edited
Loading

This is affecting the priority of the node groups. Instead of them being based on the priority field inside the node groups section, they were based on the order of the node groups.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added bug Something isn't working provisioning Something related to cluster provisioning labels Jul 2, 2021
@RobertLucian RobertLucian requested a review from deliahu July 2, 2021 23:20
@RobertLucian RobertLucian merged commit d3aeb5e into master Jul 3, 2021
@RobertLucian RobertLucian deleted the fix/cluster-autoscaler-priority branch July 3, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working provisioning Something related to cluster provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu