Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cortexlabs's version kubexit to address death dependencies #2260

Merged
merged 6 commits into from
Jun 21, 2021
Merged

Use cortexlabs's version kubexit to address death dependencies #2260

merged 6 commits into from
Jun 21, 2021

Conversation

vishalbollu
Copy link
Contributor

closes #2217

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested review from deliahu and miguelvr June 18, 2021 02:00
deliahu
deliahu approved these changes Jun 18, 2021
View reviewed changes
images/kubexit/Dockerfile Show resolved Hide resolved
@vishalbollu vishalbollu merged commit 4a40057 into master Jun 21, 2021
@vishalbollu vishalbollu deleted the build-cortexlabs-kubexit branch June 21, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr left review comments

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Death dep is not honoured by kubexit if the container died before kubexit started
3 participants
@vishalbollu @deliahu @miguelvr