Add cmd to configure nodegroups on a running cluster #2246

RobertLucian · 2021-06-11T19:32:02Z

closes #2096

checklist:

run make test and make lint
test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
update docs and add any new files to summary.md (view in gitbook after merging)

cli/cmd/cluster.go

pkg/types/clusterstate/clusterstate.go

cli/cmd/cluster.go

pkg/types/clusterconfig/cluster_config.go

pkg/types/clusterstate/clusterstate.go

docs/clients/cli.md

manager/install.sh

manager/generate_eks.py

pkg/lib/maps/string.go

pkg/lib/strings/operations.go

manager/install.sh

cli/cmd/cluster.go

pkg/types/clusterstate/clusterstate.go

manager/install.sh

pkg/lib/aws/errors.go

cli/cmd/cluster.go

pkg/lib/maps/string.go

pkg/lib/strings/operations.go

pkg/types/clusterconfig/errors.go

pkg/types/clusterconfig/cluster_config.go

manager/generate_eks.py

cli/cmd/cluster.go

cli/cmd/lib_cluster_config.go

pkg/types/clusterconfig/errors.go

pkg/types/clusterstate/clusterstate.go

# Conflicts: # pkg/lib/aws/servicequotas.go # pkg/types/clusterconfig/cluster_config.go

manager/install.sh

pkg/types/clusterconfig/cluster_config.go

pkg/types/clusterconfig/network_validations.go

RobertLucian added 21 commits June 8, 2021 00:21

WIP on nodegroup adder

3b28bbd

WIP nodegroup adder cmd

6fa2e8f

Merge branch 'master' into feature/add-or-remove-ngs

d4d2bda

Use the simplified aws resource table when showing the costs

ec88c2d

WIP cluster configure

3083606

WIP cluster configure

ddd5b3e

Bug fixes

9de468a

Further fixes on the cloudformation stacks

bc3f33a

Address layout on install.sh

914233b

Add priority field to the node group config

3fcc248

Document the priority field in the docs

e8b7bf6

Make lint

19e4be5

Layout change for cluster configure cmd

cadadfa

Better reconciliation w/ cloudformation stacks

20412af

Fix number of SGs when cluster already exists

a38ec20

Quota fixes

299fb39

Further fixes

e2949c2

Improve cluster info cmd

2b445b2

Remove debugging comments

1b599a2

Nits

33c6d36

Remove the nodegroups first and then add the others

d7d394b

RobertLucian requested a review from vishalbollu June 11, 2021 19:32

RobertLucian added 2 commits June 11, 2021 22:32

Merge branch 'master' into feature/add-or-remove-ngs

df02113

Nits

2c50eb4

vishalbollu reviewed Jun 11, 2021

View reviewed changes

vishalbollu reviewed Jun 14, 2021

View reviewed changes

docs/clients/cli.md Outdated Show resolved Hide resolved

manager/install.sh Outdated Show resolved Hide resolved

manager/install.sh Outdated Show resolved Hide resolved

manager/generate_eks.py Outdated Show resolved Hide resolved

manager/generate_eks.py Outdated Show resolved Hide resolved

RobertLucian added 4 commits June 14, 2021 23:57

Separate validate functions

d6fd7b8

Simplify get cluster state package

5f385cc

Address PR comments

97e4f30

Merge branch 'master' into feature/add-or-remove-ngs

4153321

Add missing error print when stacks couldn't be retrieved

1c42ae0

RobertLucian commented Jun 14, 2021

View reviewed changes

pkg/lib/maps/string.go Outdated Show resolved Hide resolved

pkg/lib/strings/operations.go Outdated Show resolved Hide resolved

manager/install.sh Outdated Show resolved Hide resolved

cli/cmd/cluster.go Outdated Show resolved Hide resolved

Bolts and fixes

157fec7

miguelvr changed the title ~~Add cmd to add/remove/scale nodegroups on a running cluster~~ Add cmd to configure nodegroups on a running cluster Jun 15, 2021

vishalbollu reviewed Jun 15, 2021

View reviewed changes

RobertLucian added 6 commits June 15, 2021 20:50

Address PR comments

c562386

Print cluster stacks when running cluster info cmd

fb53dda

Refactor

eae2bd1

Some refactoring

262b4f5

Merge branch 'master' into feature/add-or-remove-ngs

b0fc893

Fix to the number of required SGs on configure

0068a7d

deliahu reviewed Jun 16, 2021

View reviewed changes

RobertLucian added 3 commits June 16, 2021 03:50

Merge branch 'master' into feature/add-or-remove-ngs

3bc9d13

Address PR comments

91bf390

Address merge conflicts from master

d4b5bb9

# Conflicts: # pkg/lib/aws/servicequotas.go # pkg/types/clusterconfig/cluster_config.go

vishalbollu approved these changes Jun 16, 2021

View reviewed changes

manager/install.sh Show resolved Hide resolved

pkg/types/clusterconfig/cluster_config.go Outdated Show resolved Hide resolved

pkg/types/clusterconfig/network_validations.go Show resolved Hide resolved

RobertLucian added 3 commits June 17, 2021 17:09

Merge branch 'master' into feature/add-or-remove-ngs

b58b7a6

Addressing PR comments and a fix

4d5e378

Merge branch 'master' into feature/add-or-remove-ngs

4d40100

RobertLucian merged commit d30e780 into master Jun 17, 2021

RobertLucian deleted the feature/add-or-remove-ngs branch June 17, 2021 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cmd to configure nodegroups on a running cluster #2246

Add cmd to configure nodegroups on a running cluster #2246

RobertLucian commented Jun 11, 2021 •

edited

Loading

Add cmd to configure nodegroups on a running cluster #2246

Add cmd to configure nodegroups on a running cluster #2246

Conversation

RobertLucian commented Jun 11, 2021 • edited Loading

RobertLucian commented Jun 11, 2021 •

edited

Loading