Skip to content

CaaS - fix cortex CLI #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2021
Merged

CaaS - fix cortex CLI #2194

merged 3 commits into from
May 27, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented May 27, 2021 •
edited
Loading

This PR addresses the following 2 issues:

  • Recover from encoding error on the operator
  • Prevent setting the latency to a NaN value.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label May 27, 2021
@RobertLucian RobertLucian requested a review from deliahu May 27, 2021 15:39
deliahu
deliahu approved these changes May 27, 2021
View reviewed changes
@RobertLucian RobertLucian merged commit d7c03dc into feature/caas-api May 27, 2021
@RobertLucian RobertLucian deleted the caas/fix-cortex-cli branch May 27, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu