FaaS positioning & supporting user-defined methods to handle more HTTP methods #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLucian
commented
Apr 22, 2021
# Conflicts: # test/e2e/tests/conftest.py
RobertLucian
changed the title
miguelvr
reviewed
Apr 23, 2021
deliahu
approved these changes
Apr 23, 2021
deliahu
reviewed
Apr 23, 2021
# Conflicts: # pkg/cortex/serve/cortex_internal/lib/api/__init__.py # pkg/cortex/serve/cortex_internal/lib/api/api.py # pkg/cortex/serve/cortex_internal/serve/serve.py # pkg/cortex/serve/start/batch.py # pkg/cortex/serve/start/server_grpc.py # pkg/cortex/serve/start/task.py # pkg/operator/operator/k8s.go
deliahu
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2063.
Changes to the predictor implementation
Methods for Realtime API
__init__,handle_<verb>, conditionalload_model.handle_postmethod) only.__init__, any number of methods as indicated by the protobuf definition (RPC methods), conditionalload_model.Methods for Batch API
__init__,handle_batch,handle_on_job_complete.Methods for Async API
__init__,handle_async.No change to the Task API
Name of the predictor clients
Renamed
python_client/tensorflow_clienttomodel_client/tensorflow_client.Changes to the API spec
Predictor section renamed to
handler.checklist:
make testandmake lintsummary.md(view in gitbook after merging)