Skip to content

Improve error logging for Task/Batch APIs #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Feb 5, 2021

Fixes #1833.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian requested a review from deliahu February 5, 2021 02:32
@RobertLucian RobertLucian requested review from vishalbollu and removed request for deliahu February 5, 2021 19:05
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor comment as been addressed

@RobertLucian RobertLucian merged commit 18ab26c into master Feb 15, 2021
@RobertLucian RobertLucian deleted the misc/improve-error-logging branch February 15, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions from Task/Batch APIs not properly recorded to StackDriver/CloudWatch
3 participants