Skip to content

Add region to external models #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2019
Merged

Add region to external models #161

merged 5 commits into from
Jun 13, 2019

Conversation

1vn
Copy link
Contributor

@1vn 1vn commented Jun 13, 2019

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

deliahu
deliahu reviewed Jun 13, 2019
View reviewed changes
@1vn 1vn merged commit 152f39e into input-redesign Jun 13, 2019
@1vn 1vn deleted the input-redesign-api-external-region branch June 13, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1vn @deliahu