Skip to content

Check instance quotas during cluster creation #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 10, 2020
Merged

Check instance quotas during cluster creation #1537

merged 9 commits into from
Nov 10, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Nov 6, 2020

closes #1461

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu marked this pull request as ready for review November 6, 2020 16:21
deliahu
deliahu commented Nov 6, 2020
View reviewed changes
vishalbollu
vishalbollu approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

@vishalbollu vishalbollu merged commit e90e8f6 into master Nov 10, 2020
@vishalbollu vishalbollu deleted the vcpu-quota branch November 10, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that vCPU quota is sufficient for max_instances on cluster up/configure
2 participants
@deliahu @vishalbollu