Skip to content

Commit fbbf1b5

Browse files
committed
Support binary data in configmap helper
1 parent a123f54 commit fbbf1b5

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

pkg/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func InitConfigs(clusterConfig *clusterconfig.Config, operatorMetadata *clusterc
6262
}
6363

6464
func getClusterConfigFromConfigMap() (clusterconfig.Config, error) {
65-
configMapData, err := K8s.GetConfigMapData("cluster-config")
65+
configMapData, _, err := K8s.GetConfigMapData("cluster-config")
6666
if err != nil {
6767
return clusterconfig.Config{}, err
6868
}

pkg/lib/k8s/configmap.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ var _configMapTypeMeta = kmeta.TypeMeta{
3333

3434
type ConfigMapSpec struct {
3535
Name string
36-
Data map[string]string
36+
Data map[string]string // Data and BinaryData must not have overlapping keys
37+
BinaryData map[string][]byte // Data and BinaryData must not have overlapping keys
3738
Labels map[string]string
3839
Annotations map[string]string
3940
}
@@ -46,7 +47,8 @@ func ConfigMap(spec *ConfigMapSpec) *kcore.ConfigMap {
4647
Labels: spec.Labels,
4748
Annotations: spec.Annotations,
4849
},
49-
Data: spec.Data,
50+
Data: spec.Data,
51+
BinaryData: spec.BinaryData,
5052
}
5153
return configMap
5254
}
@@ -92,15 +94,15 @@ func (c *Client) GetConfigMap(name string) (*kcore.ConfigMap, error) {
9294
return configMap, nil
9395
}
9496

95-
func (c *Client) GetConfigMapData(name string) (map[string]string, error) {
97+
func (c *Client) GetConfigMapData(name string) (map[string]string, map[string][]byte, error) {
9698
configMap, err := c.GetConfigMap(name)
9799
if err != nil {
98-
return nil, err
100+
return nil, nil, err
99101
}
100102
if configMap == nil {
101-
return nil, nil
103+
return nil, nil, nil
102104
}
103-
return configMap.Data, nil
105+
return configMap.Data, configMap.BinaryData, nil
104106
}
105107

106108
func (c *Client) DeleteConfigMap(name string) (bool, error) {

pkg/operator/operator/memory_capacity.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func getMemoryCapacityFromNodes(primaryInstances []string) (map[string]*kresourc
7373
}
7474

7575
func getMemoryCapacityFromConfigMap() (map[string]*kresource.Quantity, error) {
76-
configMapData, err := config.K8s.GetConfigMapData(_memConfigMapName)
76+
configMapData, _, err := config.K8s.GetConfigMapData(_memConfigMapName)
7777
if err != nil {
7878
return nil, err
7979
}

0 commit comments

Comments
 (0)