Skip to content

Commit da86b23

Browse files
committed
Update iris example, fix estimator bugs
1 parent 1fb68cd commit da86b23

11 files changed

+33
-166
lines changed

examples/iris/app.yaml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,28 @@
11
- kind: app
22
name: iris
3+
4+
- kind: environment
5+
name: dev
6+
data:
7+
type: csv
8+
path: s3a://cortex-examples/iris.csv
9+
schema: [@sepal_length, @sepal_width, @petal_length, @petal_width, @class]
10+
11+
- kind: model
12+
name: dnn
13+
estimator: cortex.dnn_classifier
14+
target_column: @class
15+
input:
16+
numeric_columns: [@sepal_length, @sepal_width, @petal_length, @petal_width]
17+
target_vocab: ['Iris-setosa', 'Iris-versicolor', 'Iris-virginica']
18+
hparams:
19+
hidden_units: [4, 2]
20+
training:
21+
batch_size: 10
22+
num_steps: 1000
23+
24+
- kind: api
25+
name: iris-type
26+
model: @dnn
27+
compute:
28+
replicas: 1

examples/iris/resources/aggregates.yaml

Lines changed: 0 additions & 44 deletions
This file was deleted.

examples/iris/resources/apis.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

examples/iris/resources/models.yaml

Lines changed: 0 additions & 19 deletions
This file was deleted.

examples/iris/resources/raw_columns.yaml

Lines changed: 0 additions & 53 deletions
This file was deleted.

examples/iris/resources/transformed_columns.yaml

Lines changed: 0 additions & 38 deletions
This file was deleted.

pkg/estimators/boosted_trees_regressor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def create_estimator(run_config, model_config):
5959
)
6060
)
6161

62-
return tf.estimator.BoostedTreesClassifier(
62+
return tf.estimator.BoostedTreesRegressor(
6363
feature_columns=feature_columns,
6464
n_batches_per_layer=model_config["hparams"]["batches_per_layer"],
6565
weight_column=model_config["input"].get("weight_column", None),

pkg/estimators/dnn_linear_combined_classifier.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def create_estimator(run_config, model_config):
55
dnn_feature_columns = []
66

77
for col_name in model_config["input"]["dnn_columns"]["numeric_columns"]:
8-
feature_columns.append(tf.feature_column.numeric_column(col_name))
8+
dnn_feature_columns.append(tf.feature_column.numeric_column(col_name))
99

1010
for col_info in model_config["input"]["dnn_columns"]["categorical_columns_with_vocab"]:
1111
col = tf.feature_column.categorical_column_with_vocabulary_list(
@@ -114,7 +114,7 @@ def create_estimator(run_config, model_config):
114114
target_vocab = model_config["input"]["target_vocab"]
115115
num_classes = len(target_vocab)
116116

117-
return tf.estimator.DNNClassifier(
117+
return tf.estimator.DNNLinearCombinedClassifier(
118118
linear_feature_columns=linear_feature_columns,
119119
dnn_feature_columns=dnn_feature_columns,
120120
n_classes=num_classes,

pkg/estimators/dnn_linear_combined_regressor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def create_estimator(run_config, model_config):
55
dnn_feature_columns = []
66

77
for col_name in model_config["input"]["dnn_columns"]["numeric_columns"]:
8-
feature_columns.append(tf.feature_column.numeric_column(col_name))
8+
dnn_feature_columns.append(tf.feature_column.numeric_column(col_name))
99

1010
for col_info in model_config["input"]["dnn_columns"]["categorical_columns_with_vocab"]:
1111
col = tf.feature_column.categorical_column_with_vocabulary_list(
@@ -101,7 +101,7 @@ def create_estimator(run_config, model_config):
101101
)
102102
)
103103

104-
return tf.estimator.DNNClassifier(
104+
return tf.estimator.DNNLinearCombinedRegressor(
105105
linear_feature_columns=linear_feature_columns,
106106
dnn_feature_columns=dnn_feature_columns,
107107
dnn_hidden_units=model_config["hparams"]["dnn_hidden_units"],

pkg/estimators/linear_classifier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def create_estimator(run_config, model_config):
5757
target_vocab = model_config["input"]["target_vocab"]
5858
num_classes = len(target_vocab)
5959

60-
return tf.estimator.DNNClassifier(
60+
return tf.estimator.LinearClassifier(
6161
feature_columns=feature_columns,
6262
n_classes=num_classes,
6363
label_vocabulary=target_vocab,

pkg/estimators/linear_regressor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def create_estimator(run_config, model_config):
4444
)
4545
)
4646

47-
return tf.estimator.DNNRegressor(
47+
return tf.estimator.LinearRegressor(
4848
feature_columns=feature_columns,
4949
weight_column=model_config["input"].get("weight_column", None),
5050
config=run_config,

0 commit comments

Comments
 (0)