Skip to content

Commit d4d7e30

Browse files
authored
Fix on-job-complete request not having json body (#2409)
1 parent 95329cc commit d4d7e30

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

pkg/enqueuer/enqueuer.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ type JobSubmission struct {
7878
DelimitedFiles *DelimitedFiles `json:"delimited_files"`
7979
}
8080

81+
type onJobCompleteRequestBody struct {
82+
Message string `json:"message"`
83+
}
84+
8185
func randomMessageID() string {
8286
return random.String(40) // maximum is 80 (for sqs.SendMessageBatchRequestEntry.Id) but this ID may show up in a user error message
8387
}
@@ -127,10 +131,17 @@ func (e *Enqueuer) Enqueue() (int, error) {
127131
}
128132
}
129133

134+
onJobCompleteBodyBytes, err := json.Marshal(onJobCompleteRequestBody{
135+
Message: "job_complete",
136+
})
137+
if err != nil {
138+
return 0, err
139+
}
140+
130141
randomID := randomMessageID()
131142
_, err = e.aws.SQS().SendMessage(&sqs.SendMessageInput{
132143
QueueUrl: aws.String(e.queueURL),
133-
MessageBody: aws.String("\"job_complete\""),
144+
MessageBody: aws.String(string(onJobCompleteBodyBytes)),
134145
MessageDeduplicationId: aws.String(randomID), // prevent content based deduping
135146
MessageGroupId: aws.String(randomID), // aws recommends message group id per message to improve chances of exactly-once
136147
MessageAttributes: map[string]*sqs.MessageAttributeValue{

0 commit comments

Comments
 (0)