Skip to content

Commit c2c7bb3

Browse files
committed
Fix for job added when already on pile
1 parent 05b229d commit c2c7bb3

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ function getBadgeData(data) {
413413
report['color'] = 'orange';
414414
// Check test isn't already on the pile
415415
let onPile = false;
416-
for (let job of queue.pile) { if (job.id === id) { onPile = true; break; } }
416+
for (let job of queue.pile) { if (job.data.sha === id) { onPile = true; break; } }
417417
if (!onPile) { // Add test to queue
418418
data['skipPost'] = true
419419
queue.add(data);

test/lib.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,11 @@ describe("getBadgeData function", () => {
318318
data = lib.getBadgeData(input);
319319
expect(data).to.deep.equal(expected);
320320
sandbox.assert.calledOnce(queue.add);
321+
322+
// Shouldn't add as job already queued
323+
data = lib.getBadgeData(input);
324+
expect(data).to.deep.equal(expected);
325+
sandbox.assert.calledOnce(queue.add);
321326
});
322327

323328
it('Check force flag', function () {

0 commit comments

Comments
 (0)