Remove console error imports #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 10. |
|
Visit the preview URL for this PR (updated for commit 7e844a4): https://cornelldti-courseplan-dev--pr648-fix-bootstrap-error-9odu3hd5.web.app (expires Wed, 16 Feb 2022 03:23:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
4 tasks
einc
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Thanks for getting to this so fast!
Tested and no errors appear in console log. I don’t see any differences on the landing page, onboarding, or mobile either.
We haven’t merged any PRs since Jan release, so pushing to prod (if we want) should be easy as it’s just this PR! @jessfeng thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes the imports that are failing in the console on CoursePlan.io as a result of Vue being updated to
v3.2.30. As noted in #496, a similar attempt to remove a broken import, we manage Bootstrap through NPM and thus do not need the import lines that are failing.Test Plan
Ensure that the errors do not appear in the console logs of the deploy link.
Additionally, confirm CP works and is styled as expected. Specifically - confirm styling on the landing page, onboarding modal, and mobile views look as expected
Notes
Do we want to push to prod after this is merged since the console errors are on the live site?
Blockers
This resolves the blocker on all current PRs with the Cypress tests failing because there were console errors.