-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add f16 dtype support for tensors #423
Comments
See #421 for draft of what adding another dtype looks like |
I've started work on this, but I've encountered a major issue. |
@nkoppel How far along are you in the implementation? I am interested in working on the cuda side of things. |
What about making a wrapper for f16 and implementing SampleUniform (and other needed traits)? |
I was just looking into this a bit for the half crate, but even when implementing SampleUniform you run into foreign traits. So I think even we did a wrapper type we would need some changes from rand/rand_distr I think |
Okay just kidding I was missing something! I have a PR opened in half, so hopefully we can depend on that |
Is anyone still working on this? I'd work on it but I wouldn't want to redo things. |
I'm not - still waiting on half crate to merge my PR. You can probably start working on this if you use my fork of half with the update |
This can use the
half
crate.Cuda has many arithmetic functions available for half as seen here
hgemm support depends on coreylowman/cudarc#65
The text was updated successfully, but these errors were encountered: