From 6efa0cca51466dee58faf69f631620933f3fd255 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Ravier?= <tim@siosm.fr>
Date: Wed, 28 Jun 2023 12:14:14 +0200
Subject: [PATCH] Fix ShellCheck errors and warnings

```
In ./rhcos-toolbox line 21:
        source "${TOOLBOXRC}"
               ^------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./rhcos-toolbox line 48:
    local runlabel=$(image_runlabel)
          ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./rhcos-toolbox line 63:
    local state=$(container_state)
          ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./rhcos-toolbox line 183:
        echo "${@}; exit" | sudo podman attach "${TOOLBOX_NAME}"
              ^--^ SC2145 (error): Argument mixes string and array. Use * or separate argument.
```
---
 rhcos-toolbox | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/rhcos-toolbox b/rhcos-toolbox
index a1b59f2..ee441f4 100755
--- a/rhcos-toolbox
+++ b/rhcos-toolbox
@@ -18,6 +18,8 @@ setup() {
     # Allow user overrides
     if [ -f "${TOOLBOXRC}" ]; then
         errecho ".toolboxrc file detected, overriding defaults..."
+        # This file only potentially exists on a running system
+        # shellcheck disable=SC1090
         source "${TOOLBOXRC}"
     fi
     TOOLBOX_IMAGE="${REGISTRY}"/"${IMAGE}"
@@ -45,7 +47,8 @@ run() {
 
     # If the container does not already exists, create it, while making sure to
     # use the option from the RUN label if provided
-    local runlabel=$(image_runlabel)
+    local runlabel
+    runlabel=$(image_runlabel)
     if ! container_exists; then
         errecho "Spawning a container '${TOOLBOX_NAME}' with image '${TOOLBOX_IMAGE}'"
         if [[ -z "${runlabel}" ]] || [[ "${runlabel}" == "<no value>" ]]; then
@@ -60,7 +63,8 @@ run() {
     fi
 
     # Start our freshly created container
-    local state=$(container_state)
+    local state
+    state=$(container_state)
     if [[ "${state}" == configured ]] || [[ "${state}" == created ]] || [[ "${state}" == exited ]] || [[ "${state}" == stopped ]]; then
         container_start
     elif [[ "${state}" != running ]]; then
@@ -180,7 +184,7 @@ container_exec() {
     if [[ "$#" -eq 0 ]]; then
         sudo podman attach "${TOOLBOX_NAME}"
     else
-        echo "${@}; exit" | sudo podman attach "${TOOLBOX_NAME}"
+        echo "${*}; exit" | sudo podman attach "${TOOLBOX_NAME}"
     fi
 }