Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor container-image-proxy #3160

Closed
cgwalters opened this issue Oct 6, 2021 · 2 comments
Closed

vendor container-image-proxy #3160

cgwalters opened this issue Oct 6, 2021 · 2 comments

Comments

@cgwalters
Copy link
Member

cgwalters commented Oct 6, 2021

In order to use #3139 we need https://github.com/cgwalters/container-image-proxy

The thread in cgwalters/container-image-proxy#1 discusses the long term productization for that.

Short term, I'd just like to get this code out into an rpm-ostree release, still under --experimental so it's easier for people to try.

The proposal here is:

  • git submodule add container-image-proxy https://github.com/cgwalters/container-image-proxy
  • Build and ship it in the rpm-ostree RPM for now, installed in e.g. /usr/lib/rpm-ostree/container-image-proxy

Two questions:

  • Any objections?
  • Is there a better way to do this?
@jlebon
Copy link
Member

jlebon commented Oct 6, 2021

No strong objection, though it's going to be really confusing having golang, C, C++, and Rust in a single codebase.

Have you approached the containers team about cgwalters/container-image-proxy#1 yet? I wonder if they'd be open to shipping it as a subpackage of skopeo for now.

@cgwalters
Copy link
Member Author

though it's going to be really confusing having golang, C, C++, and Rust in a single codebase.

Well...it's not in a single process. I think touching the proxy code would be rare. But yes, OK:
OK containers/skopeo#1476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants