Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AWS Init function logic for waiting for networking #1158

Open
arithx opened this issue Jan 6, 2021 · 0 comments
Open

Refactor AWS Init function logic for waiting for networking #1158

arithx opened this issue Jan 6, 2021 · 0 comments

Comments

@arithx
Copy link
Contributor

arithx commented Jan 6, 2021

Feature Request

In #1155 we settled on a temporary solution of using a FetchToBuffer call inside of the platform Init function for AWS to handle waiting for networking to come up before attempting to fetch the region hint from the metadata service. See this comment for more information about why the decision was chosen.

Some alternative potential solutions:

  1. Adding a Retryer to the aws.Config so the AWS API handles retrying (by default it seems that there would only ever be a single retry)
  2. Fetching the region hint from an HTTP URL instead of the AWS API
  3. Putting the API call inside a retry loop (we need to test out the different failure states to make sure that we're only retrying in the case of network/platform errors)

We also need to note the fact that if we do indeed move away from using a FetchToBuffer call we'll need to handle checking the Offline state inside of the Init function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants