Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a coreos-assembler stable release to work with the stable branch of fedora-coreos-config #602

Closed
junjiequ opened this issue Aug 12, 2020 · 3 comments

Comments

@junjiequ
Copy link

Hi,

I found myself in this situation: I could use neither the v0.8.1 tag (too old) nor the master tag (too new) of the coreos-assembler to build the stable branch of the fedora-coreos-config repo.

The main cause here I think is the commit below:
coreos/coreos-assembler@6f533ef#diff-f5e5c331891c4081b21b1f733752ba12
I couldn't see the corresponding commit promoted to the stable branch of fedora-coreos-config yet... It's still sitting in the testing-devel branch: coreos/fedora-coreos-config@346f770

I think the same dependency issue would happend to the coreos-installer as well..

It's great to see new changes happening all the time. But I couldn't create a new custom build using the latest tooling, and there is no fallback build of coreos-assembler I could use, which is a bit headache for me.

What would be the recommended approach to build the stable branch of the fedora-coreos-config repo while the coreos-assembler develops in such an advanced pace? i.e., Is there any milestone plan that we could refer to?

@bgilbert
Copy link
Contributor

In this case, there's a coreos-assembler branch for building the stable fedora-coreos-config. In general, we try not to get into this situation too often.

coreos-installer tries to be independent of specific FCOS releases and there isn't a version dependency in this case.

@jlebon
Copy link
Member

jlebon commented Aug 12, 2020

Normally, we try to avoid this issue by making the new coreos-assembler behaviour conditional on a new knob in e.g. image.yaml. For this, we missed the compatibility constraints during code review.

We also have an outstanding issue in https://github.com/coreos/fedora-coreos-streams/issues/64 to investigate automatically pinning cosa whenever we do an FCOS release. For now, as Benjamin said we manually fork off a temporary branch whenever required.

@junjiequ
Copy link
Author

Great! Thank you guys for the quick answer.

In the mean time I also found that this was mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants