mantle/kola: rework fcos.upgrade.basic #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
force-pushed
the
dusty-kola-upgrade
branch
2 times, most recently
from
1fd3649
to
d152b3b
Compare
|
Minor: Commit message typo |
yeah. I can just fix it and force push and then immediately merge (if you approve) |
|
yep, let's do that. Rest lgtm |
Since we are dropping a config fragment down that has higher priority than all the others that try to disable updates from various sources (i.e. dev build, non-production build, etc) then we don't need to worry about deleting them. Let's just let the higher priority config win. This also means we don't have to start and stop and start and stop zincati so many times. Let's just start the machine with it disabled and then start it when we've got the infra in place for it to recognize and apply an update. This may help avoid some race conditions now or in the future.
The config was updated in 3c74005 to add steady_interval_secs but in reality it's more convenient for us to just start zincati here anyway. Let's drop the instructions to update, since we're just planning on keeping this here now anyway.
The referenced issue in coreos#1301 has long since been fixed.
dustymabe
force-pushed
the
dusty-kola-upgrade
branch
from
d152b3b
to
8a1741a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in here trying to understand the test a bit more since we have been seeing some flakiness lately and decided to do some cleaning up. See individual commit messages.