Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that there is console output / a login prompt to make sure getty works #3832

Open
travier opened this issue Jul 10, 2024 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers good-first-issue good issue for someone new jira for syncing to jira

Comments

@travier
Copy link
Member

travier commented Jul 10, 2024

Feature Request

See: coreos/fedora-coreos-tracker#1758

Make sure that users can interact with the console and login.

Desired Feature

N/A

Example Usage

N/A

Other Information

N/A

@travier travier added enhancement New feature or request good first issue Good for newcomers jira for syncing to jira good-first-issue good issue for someone new labels Jul 10, 2024
@Prashanna313
Copy link

Interested to pick

@jlebon
Copy link
Member

jlebon commented Jul 15, 2024

Probably simplest for this is to add it to the list of console checks we do (i.e. add to the consoleChecks array in harness.go). Though currently that checks for bad things; we'd need to add another field to the struct to invert the polarity.

Feels weird to check on every test, though at the same time, it's very rare the cases where we don't expect a login prompt. Probably want to add a skip tag too if there are cases where indeed we don't (I know that happens in one of the testiso scenarios, but not in the primary kola run AFAIK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers good-first-issue good issue for someone new jira for syncing to jira
Projects
None yet
Development

No branches or pull requests

3 participants