Skip to content

Commit 0cb63a8

Browse files
committed
src/kola: Add '--skip-secure-boot' option to skip Secure Boot tests
This makes skipping those tests easier in downstream pipelines that call `cosa kola run --basic-qemu-scenarios`.
1 parent 3d89e1a commit 0cb63a8

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/cmd-kola

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import sys
1010
# Just test these boot to start with. In the future we should at least
1111
# do ostree upgrades with uefi etc. But we don't really need the *full*
1212
# suite...if podman somehow broke with nvme or uefi I'd be amazed and impressed.
13-
BASIC_SCENARIOS = ["nvme=true", "firmware=uefi", "firmware=uefi-secure"]
13+
BASIC_SCENARIOS = ["nvme=true", "firmware=uefi"]
14+
BASIC_SCENARIOS_SECURE_BOOT = ["firmware=uefi-secure"]
1415
arch = platform.machine()
1516

1617
cosa_dir = os.path.dirname(os.path.abspath(__file__))
@@ -25,6 +26,7 @@ parser = argparse.ArgumentParser()
2526
parser.add_argument("--build", help="Build ID")
2627
parser.add_argument("--basic-qemu-scenarios", help="Run the basic test across uefi-secure,nvme etc.", action='store_true')
2728
parser.add_argument("--output-dir", help="Output directory")
29+
parser.add_argument("--skip-secure-boot", help="Use with '--basic-qemu-scenarios' to skip the Secure Boot tests", action='store_true')
2830
parser.add_argument("--upgrades", help="Run upgrade tests", action='store_true')
2931
parser.add_argument("subargs", help="Remaining arguments for kola", nargs='*',
3032
default=[])
@@ -63,6 +65,11 @@ if args.basic_qemu_scenarios:
6365
subargs = kolaargs + ['--qemu-' + scenario, 'basic']
6466
print(subprocess.list2cmdline(subargs), flush=True)
6567
subprocess.check_call(subargs)
68+
if not args.skip_secure_boot:
69+
for scenario in BASIC_SCENARIOS_SECURE_BOOT:
70+
subargs = kolaargs + ['--qemu-' + scenario, 'basic']
71+
print(subprocess.list2cmdline(subargs), flush=True)
72+
subprocess.check_call(subargs)
6673
else:
6774
# Basic qemu scenarios using nvme and uefi
6875
# are not supported on multi-arch

0 commit comments

Comments
 (0)