Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: sometimes yarn install adds a different web3.js version & wallet doesn't load #70

Open
wentokay opened this issue May 23, 2022 · 2 comments

Comments

@wentokay
Copy link
Collaborator

problem:

Screenshot 2022-05-23 at 11 44 34

cross-fetch dependency is incompatible with workers

short term solution:

ensure every package is using same solana version (see resolutions field in package.json) and then patch that version.

we're doing this now, but sometimes a different version of solana still makes it into the yarn.lock file, so it doesn't get patched

long term solution:

open PR in solana/web3.js repo to remove cross-fetch

@wentokay
Copy link
Collaborator Author

opened a PR in web3.js to replace cross-fetch with isomorphic-unfetch solana-labs/solana#25500

@wentokay
Copy link
Collaborator Author

the PR was rejected but there are plans to hopefully remove cross-fetch at some point solana-labs/solana#25014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant