Corentin/universal #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the name of a template variable or concept in places where an expression was expected, Clang would drop the cxxscope token preceeding it, if any. This leads to subpar diagnostics - complaining about the identifier being undeclared as clang would not know to look into a non-global scope. We make sure the scope is preserved. When encountering `ns::Concept foo x;`, Clang would also fail to provide the same quality as it does at global scope. Differential Revision: https://reviews.llvm.org/D146719
* Expressions of the form `Concept<ConceptName>` are normalized by instantiating `ConceptName` in `Concept` associated constraints and normaliziing that instantiatiation's associated constraints. * Normalize fold expressions (http://cplusplus.github.io/concepts-ts/ts-active.html#28)
and no <, for function calls
Thhis is currently disabled because it is not clear whether that is actually implementable.
cor3ntin
force-pushed
the
corentin/universal
branch
from
3a46373
to
b93e741
Compare
cor3ntin
force-pushed
the
corentin/universal
branch
from
eb59616
to
d658277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.