-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix testing and node requirements #657
Comments
Hi, I have changed the requirement of Node.js 20 while ago in 0.6.6. See this: dee4b75#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 I removed Node.js 18.x from tests: 6cef36e |
The note at changelog is sufficient. I did not check back so long. My Fault sorry. Changin minor after so many releases does not make sense. So everything is finde after Adaption nodejs at Tests. |
Does this look ok? https://github.com/copystring/ioBroker.roborock/blob/dev/.github/workflows/test-and-release.yml |
I'll check later. I'm just leasing for about 5 days of holiday. Normally lintcand deploy should work with all node versions. Butckeep it as it is for now. Please post a link of the failed run if available. |
I fixed lint and deploy by changing the canvas lib to @napi-rs/canvas. I wanted to change the canvas lib a while ago anyway. Also, canvas didn't seem to work with node 22.x and the 3.0.0-rc2 wasn't working on Windows. |
Bug Description
Testing must be performed at ALL supported platforms (linux, windows, macos). So please add macos to testing matrix (Update test-and-release.yml - add macos-latest #656).
If macos cannot be supported (tests at PR fail), please state this restriction at README.md and add list of supported os at io-package.json:
https://github.com/ioBroker/ioBroker.js-controller/blob/4e8189ae010aadbff9fb35ee4b3861b5e29992c4/schemas/io-package.json#L1335
Testing includes nodeJs 18 while package.json states node 20 minimum. Please fix (remove node 18 from tests)
ioBroker.roborock/package.json
Line 23 in f386a19
Please note that encreasing the need for a higher nodJs version should be reflected by an minor version bump at least.
Please add requirment encrease to nodeJs 20 to README.md
Steps to Reproduce
see description
Expected Behavior
see description
Debug Log
n/a
Adapter Version
Github f386a19
JS-Controller Version
n/a
Node.js Version
n/a
Operating System
n/a
Additional Context
No response
The text was updated successfully, but these errors were encountered: