Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix testing and node requirements #657

Open
3 of 4 tasks
mcm1957 opened this issue Sep 23, 2024 · 5 comments
Open
3 of 4 tasks

Please fix testing and node requirements #657

mcm1957 opened this issue Sep 23, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 23, 2024

Bug Description

Steps to Reproduce

see description

Expected Behavior

see description

Debug Log

n/a

Adapter Version

Github f386a19

JS-Controller Version

n/a

Node.js Version

n/a

Operating System

n/a

Additional Context

No response

@mcm1957 mcm1957 added the bug Something isn't working label Sep 23, 2024
@copystring
Copy link
Owner

Hi,

I have changed the requirement of Node.js 20 while ago in 0.6.6. See this: dee4b75#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Is this sufficient in the changelog, or do I need to mention the requirement of Node.js 20.x elsewhere in the README?
I did not bump the minor version back then. How should I handle the situation now?

I removed Node.js 18.x from tests: 6cef36e

@mcm1957
Copy link
Contributor Author

mcm1957 commented Sep 23, 2024

The note at changelog is sufficient. I did not check back so long. My Fault sorry.

Changin minor after so many releases does not make sense.

So everything is finde after Adaption nodejs at Tests.

@copystring
Copy link
Owner

copystring commented Sep 23, 2024

Does this look ok? https://github.com/copystring/ioBroker.roborock/blob/dev/.github/workflows/test-and-release.yml
18.x can stay for lint and deploy? I tried it with 20.x, but it fails, missing some libraries.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Sep 24, 2024

I'll check later. I'm just leasing for about 5 days of holiday. Normally lintcand deploy should work with all node versions. Butckeep it as it is for now. Please post a link of the failed run if available.

@copystring
Copy link
Owner

I fixed lint and deploy by changing the canvas lib to @napi-rs/canvas. I wanted to change the canvas lib a while ago anyway. Also, canvas didn't seem to work with node 22.x and the 3.0.0-rc2 wasn't working on Windows.
See this run: #660
I guess all issues are solved. Waiting for your feedback when you have time. I don't mind waiting for after your holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants