-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Virt-io Console device. #949
Conversation
48eab79
to
751f346
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is useful to check the existing virtio implemention, and eventually could serve as a better console for some of the modern OSes.
I have left a few stylistic remarks, but overall this looks good.
I've tested this on the archlinux profile and the device is detected and seems to work.
If you rebase, the test failure should go away.
What's missing (not necessarily in this PR):
- A test. Unfortunately the small Linux images haven't been configured with virtio-console support, so this will have to wait for later
- Integration into xtermjs (e.g. a
virtio_console_container_xtermjs
parameter, analogous toserial_container_xtermjs
) - Some documentation on how to use this, at least on Linux
Thanks for the feedback. I'll get the style cleaned up. For testing I made a custom Alpine Linux based image that weights about 26mb (6mb kernel, 20mb initramfs). Would a test based on that work, or is it still a bit too large? |
751f346
to
63143c1
Compare
Implements a virtio console device. This allows reading and writing buffers in bulk as well as a channel to communicate terminal size updates.
63143c1
to
226569c
Compare
Yes, that would be useful. |
Thanks! I've added a test in 609d794 |
Implements a virtio console device. This allows reading and writing buffers in bulk as well as a channel to communicate terminal size updates.