Added conditional checks in controller for better testing

Added angularjs tests for CustomerController

Author: Robert Leggett

src/main/webapp/WEB-INF/resources/js/custom/controller.js

@@ -19,21 +19,31 @@ app.controller('CustomerController', function ($scope, CustomerService) {
 
     $scope.delete = function(id) {
         CustomerService.deleteCustomer(id).then(function(response) {
-            angular.forEach($scope.customers, function(customer, index) {
-                if(id == customer.id) {
-                    $scope.customers.splice(index, 1);
+            if(response) {
+                angular.forEach($scope.customers, function (customer, index) {
+                    if (id == customer.id) {
+                        $scope.customers.splice(index, 1);
 
-                    console.info("Customer " + id + " has been deleted.")
-                }
-            });
+                        console.info("Customer " + id + " has been deleted.")
+                    }
+                });
+            }
+            else {
+                console.error("Customer " + id + " was unable to be deleted.")
+            }
         });
     };
 
     $scope.save = function(id) {
         angular.forEach($scope.customers, function(customer, index) {
             if(id == customer.id) {
                 CustomerService.saveCustomer(customer).then(function(response) {
-                    console.info("Customer " + id + " has been saved.")
+                    if(response) {
+                        console.info("Customer " + id + " has been saved.")
+                    }
+                    else {
+                        console.error("Customer " + id + " was unable to be saved.")
+                    }
                 });
             }
         });

src/test/webapp/WEB-INF/resources/js/custom/controller.spec.js

@@ -1,5 +1,5 @@
 describe('CustomerController Tests', function() {
-    var $rootScope, $controller, mockCustomerService, deferred, spyPromise;
+    var $rootScope, $controller, mockCustomerService, deferred, spyPromise, customerData;
 
     beforeEach(function() { module('app'); });
 
@@ -17,6 +17,14 @@ describe('CustomerController Tests', function() {
 
             // initialize controller
             $controller = _$controller_('CustomerController', {'$scope': $rootScope, CustomerService : mockCustomerService });
+
+            // define initial customer data
+            customerData = [
+                {"id": 1, "firstName": "Foo", "lastName": "Bar"},
+                {"id": 2, "firstName": "Jim", "lastName": "Sunny"},
+                {"id": 3, "firstName": "Peter", "lastName": "Prone"},
+                {"id": 4, "firstName": "Sam", "lastName": "Sully"}
+            ];
         })
     );
 
@@ -49,19 +57,122 @@ describe('CustomerController Tests', function() {
         it('should have scope variable customers populated', function () {
             $rootScope.init();
 
-            deferred.resolve([
-                {"id": 1, "firstName": "Foo", "lastName": "Bar"},
-                {"id": 2, "firstName": "Jim", "lastName": "Sunny"},
-                {"id": 3, "firstName": "Peter", "lastName": "Prone"},
-                {"id": 4, "firstName": "Sam", "lastName": "Sully"}
-            ]);
+            deferred.resolve(customerData);
 
             $rootScope.$apply();
 
-            expect($rootScope.customers).toEqual([ { id : 1, firstName : 'Foo', lastName : 'Bar' }, { id : 2, firstName : 'Jim', lastName : 'Sunny' }, { id : 3, firstName : 'Peter', lastName : 'Prone' }, { id : 4, firstName : 'Sam', lastName : 'Sully' } ]);
+            expect($rootScope.customers).toEqual(customerData);
             expect(mockCustomerService.getCustomers).toHaveBeenCalled();
         });
     });
+
+    describe('CustomerController Save Tests', function() {
+
+        beforeEach(function() {
+            spyOn(console, 'error');
+
+            $rootScope.customers = customerData;
+
+            //setup the spy to always return the spyPromise for the entire test spec
+            mockCustomerService.saveCustomer.and.returnValue(spyPromise);
+        });
+
+        it('should initially has customers populated before any calls are made', function(){
+            expect($rootScope.customers).toEqual(customerData);
+        });
+
+        it('should have not saved any data with service call returning true', function () {
+            $rootScope.save(2);
+
+            deferred.resolve(true);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual(customerData);
+            expect(mockCustomerService.saveCustomer).toHaveBeenCalled();
+            expect(console.error).not.toHaveBeenCalled();
+        });
+
+        it('should have not saved any data with service call returning false', function () {
+            $rootScope.save(2);
+
+            deferred.resolve(false);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual(customerData);
+            expect(mockCustomerService.saveCustomer).toHaveBeenCalled();
+            expect(console.error).toHaveBeenCalled();
+        });
+
+        it('should have not saved any data with customers undefined', function () {
+            $rootScope.customers = undefined;
+
+            $rootScope.save(2);
+
+            deferred.resolve(false);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual(undefined);
+            expect(mockCustomerService.saveCustomer).not.toHaveBeenCalled();
+            expect(console.error).not.toHaveBeenCalled();
+        });
+    });
+
+    describe('CustomerController Delete Tests', function() {
+
+        beforeEach(function() {
+            spyOn(console, 'error');
+
+            $rootScope.customers = customerData;
+
+            //setup the spy to always return the spyPromise for the entire test spec
+            mockCustomerService.deleteCustomer.and.returnValue(spyPromise);
+        });
+
+        it('should initially has customers populated before any calls are made', function(){
+            expect($rootScope.customers).toEqual(customerData);
+        });
+
+        it('should have scope variable customers populated with deleted customer removed', function () {
+            $rootScope.delete(2);
+
+            deferred.resolve(true);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual([ { id : 1, firstName : 'Foo', lastName : 'Bar' }, { id : 3, firstName : 'Peter', lastName : 'Prone' }, { id : 4, firstName : 'Sam', lastName : 'Sully' } ]);
+            expect(mockCustomerService.deleteCustomer).toHaveBeenCalled();
+            expect(console.error).not.toHaveBeenCalled();
+        });
+
+        it('should have not deleted any data with service call returning false', function () {
+            $rootScope.delete(2);
+
+            deferred.resolve(false);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual(customerData);
+            expect(mockCustomerService.deleteCustomer).toHaveBeenCalled();
+            expect(console.error).toHaveBeenCalled();
+        });
+
+        it('should have not deleted any data with customers undefined', function () {
+            $rootScope.customers = undefined;
+
+            $rootScope.delete(2);
+
+            deferred.resolve(false);
+
+            $rootScope.$apply();
+
+            expect($rootScope.customers).toEqual(undefined);
+            expect(mockCustomerService.deleteCustomer).toHaveBeenCalled();
+            expect(console.error).toHaveBeenCalled();
+        });
+    });
 });
 
 describe('MainController Tests', function() {