Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mypy copier --strict pass #1441

Closed
bswck opened this issue Nov 29, 2023 · 4 comments
Closed

Make mypy copier --strict pass #1441

bswck opened this issue Nov 29, 2023 · 4 comments
Labels
enhancement good first issue Easy things for newbies

Comments

@bswck
Copy link

bswck commented Nov 29, 2023

Actual Situation

mypy copier --strict fails with 68 errors in 7 files (checked 11 source files).
Checked on compiled mypy 1.5.1, Python 3.8.17.

Desired Situation

mypy copier --strict passes successfully.

Proposed solution

Resolve all errors reported by mypy.
A followup to #1431.

@yajo yajo added this to the Community contribution milestone Nov 29, 2023
@yajo yajo added the good first issue Easy things for newbies label Nov 29, 2023
@bswck
Copy link
Author

bswck commented Dec 8, 2023

I want to see autorefine in the action of semi-auto-resolving this, as soon as it's ready. I want to get your code-reviewer feedback afterwards.

@Lujeni
Copy link

Lujeni commented Jan 9, 2024

Hey @bswck ! Thanks for this nice project

Is it possible to propose a batch of small pull requests in order to fix specific mypy errors or would you prefer a single PR to fix all of them?

@bswck
Copy link
Author

bswck commented Jan 9, 2024

Hey @bswck ! Thanks for this nice project

Is it possible to propose a batch of small pull requests in order to fix specific mypy errors or would you prefer a single PR to fix all of them?

Thanks for reaching out. If you want to fix this issue, then I guess you might make a single pull request with bulk fixes in logically separated commits, in line with the contributing guide.

If you're asking about autorefine, it will aim to organize fixes of linting and typechecking errors into groups that can be separated into small pull requests for the ease of reviewing and preserving easily bisectable, clean, logically grouped SCM history.

autorefine is a very big idea, but I am currently jobless and have no time nor money to take the effort all by myself. If you would like to help, let's get in touch.

@sisp
Copy link
Member

sisp commented Apr 7, 2024

Resolved via #1527.

@sisp sisp closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Easy things for newbies
Projects
None yet
Development

No branches or pull requests

4 participants