-
Notifications
You must be signed in to change notification settings - Fork 69
Upgrade to Bootstrap v5 #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
they removed that and now the font-size was being this 14px but there were some thing to adapt
@franpb14 couple of minor issues I just noticed:
About this point:
No need to change it, IMO the current defaults are totally fine for now. I'd like to make some overall adjustments (buttons, inputs, ...) but in future iterations. |
@franpb14 just made another round of 👀 and I think overall looks quite stable now, the only thing that it works a bit weird is the top navbar in mobile: ![]()
|
@franpb14 The navbar is still not working well:
![]() |
Looks good now 👏 I'd probably push some tweaks 💅, but later in a different branch. I think this is ready to be merged, I'm just a bit worried about the Docker build crash. That's the same script we are using to deploy the app, so right now we cant probably deploy it 🤣 |
@markets should I ask PokeCode about the docker problem? |
@sseerrggii Would be nice 👌🏼 if they can help us to understand why this is failing and how we can fix it. |
8844fe5
to
afb1233
Compare
@franpb14 @sseerrggii going to merge this now, the Docker build failure seems unrelated at all, as it's also happening in another branches. We'll need to fix that of course, but in the meantime we can continue iterating on |
Main points