Skip to content

Set col to a different value #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

mperezv
Copy link
Collaborator

@mperezv mperezv commented Feb 17, 2020

Set .col value on tags/_grouped_index.html.erb to improve responsiveness on that view. This is how it looks now on small screens:
tags-siendo-responsive

Fix #541

@sseerrggii
Copy link
Contributor

source (2)

Good improvement @mperezv let's see how to fix travis

Copy link
Collaborator

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We just need to wait for those specs to be 🍏 . Don't forget to explain the conclusions of your investigation because you do know why they are failing now 💪 😎

@sauloperez
Copy link
Collaborator

I just merged #401 so you should be able to rebase this branch onto develop and get a 🍏 CI build.

@sseerrggii
Copy link
Contributor

Tested 🍏

@sauloperez sauloperez merged commit 5503285 into coopdevs:develop Feb 27, 2020
@mperezv mperezv deleted the fix/do-tags-view-responsive branch February 27, 2020 09:23
@sauloperez sauloperez mentioned this pull request Mar 2, 2020
@markets markets mentioned this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some words in /tags overlap on small screens
4 participants