Skip to content

fix features specs + upgrade some "group :test" gems #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2019
Merged

fix features specs + upgrade some "group :test" gems #507

merged 2 commits into from
Aug 26, 2019

Conversation

markets
Copy link
Collaborator

@markets markets commented Aug 20, 2019 •
edited
Loading

⚠️ target branch 👉 #506

@markets markets force-pushed the fix_features_specs branch from 99eb1fa to 209a0e6 Compare August 20, 2019 19:53
@markets
Copy link
Collaborator Author

markets commented Aug 20, 2019 •
edited
Loading

@enricostano @Morantron fixed ✅ Travis is passing now!
What do you think? Couple of details:

  • I need to "downgrade" to Trusty dist in Travis, new one (Xenial), comes with PostgreSQL 10.
  • I updated test gems (no runtime changes) to latest available/compatible version.

@markets markets mentioned this pull request Aug 20, 2019
Merged
@enricostano enricostano merged commit 1eb117e into fix/bundler-version-in-travis Aug 26, 2019
@enricostano enricostano deleted the fix_features_specs branch August 26, 2019 13:27
@enricostano
Copy link
Contributor

Thanks @markets 😍

@sauloperez sauloperez mentioned this pull request Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markets @enricostano