Skip to content

update to Ruby 2.6 #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2019
Merged

update to Ruby 2.6 #503

merged 1 commit into from
May 25, 2019

Conversation

markets
Copy link
Collaborator

@markets markets commented May 25, 2019

⚠️ This PR points to feature/ubuntu-bionic branch (#502)

Let's move to latest stable release :shipit:

…onse to make tests work with the combo Rails 4.2 & Ruby 2.6)
Copy link
Contributor

@enricostano enricostano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your avatar yesterday night trying to fix this issue. 😂

Do you think that the monkey patch it's worth it? Why don't we use this limitation instead to force us to upgrade Rails? What do you think?

@markets
Copy link
Collaborator Author

markets commented May 25, 2019

😂 not really fixing it last night, but got the Travis 🛑 email and I remembered that just recently I was fixing those problems in some gems...

IMHO yes, it's worth it! It's an "small" patch that not affects runtime, only controller tests. Since we are going to do a Ruby upgrade and test/review all app... why not? It doesn't force us to upgrade Rails right now either, and anyway, we should start to think in a Rails upgrade, our current version 4.2.Z is almost out of "Severe Security Issues" (Rails 6 is in rc already).

@enricostano
Copy link
Contributor

It doesn't force to upgrade Rails right now either, and anyway, we should start to think in a Rails upgrade, our current version 4.2.Z is almost out of "Severe Security Issues" (Rails 6 is in rc already).

That's my point, we have to upgrade Rails ASAP. And that will bring latest Ruby with it.

It's an "small" patch that not affects runtime, only controller tests. Since we are going to do a Ruby upgrade and test/review all app... why not?

OK then, let's do this! Thanks for your help as always 💪❤️

@enricostano enricostano merged commit ab077a6 into feature/ubuntu-bionic May 25, 2019
@enricostano enricostano deleted the ruby_2_6 branch May 25, 2019 17:22
@markets
Copy link
Collaborator Author

markets commented May 25, 2019

I am a volunteer to work on the Rails upgrade ✋

Thanks @enricostano! 👌 Really happy with this Ruby upgrade and the Elastic ✂️

@enricostano
Copy link
Contributor

I am a volunteer to work on the Rails upgrade

Cool! Perfect, let's plan the work needed 💪

@sauloperez sauloperez mentioned this pull request Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants